Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Hyrax to fix underlying based near #2360

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Update Hyrax to fix underlying based near #2360

merged 1 commit into from
Oct 16, 2024

Conversation

laritakr
Copy link
Collaborator

Updates Hyrax to bring in based near fix
Removes decorator which broke the form UI and is now unneeded. Screenshot below shows the location interface now is opened on an empty form.

Screenshots after change

Screenshot 2024-10-16 at 4 12 30 PM

Screenshot 2024-10-16 at 4 12 24 PM

@samvera/hyku-code-reviewers

@laritakr
Update Hyrax to fix underlying based near
fd671cd 
Updates Hyrax to bring in based near fix
Removes decorator which broke the form UI and is now unneeded
@laritakr laritakr added the patch-ver for release notes label Oct 16, 2024
@laritakr laritakr mentioned this pull request Oct 16, 2024
Open
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 16, 2024 •
edited
Loading

Test Results

    3 files  ±0      3 suites  ±0   17m 47s ⏱️ -1s
2 038 tests ±0  1 988 ✅ ±0  50 💤 ±0  0 ❌ ±0 
2 065 runs  ±0  2 013 ✅ ±0  52 💤 ±0  0 ❌ ±0 

Results for commit fd671cd. ± Comparison against base commit 69b3e60.

This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both. 
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy b3818bb5-fbea-4e0b-96d7-74894b9969c3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 45b27883-5683-4565-80d1-13b5d7dfff4e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read 5a2ebe20-6d3a-4e80-a626-b6a363448ead
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 58fec845-8f70-44e4-9917-22d3245c0262
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 2dd63ee3-1413-4ad9-91ec-48c9f9f33d66
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit a93f7aaa-9f94-4fda-b24b-988eb8829857
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 3bb20e06-5fe8-478c-82b2-6c0367d68167
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 470e83de-e4b8-47b9-bd9b-1afca3f491ba
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy ea58afb7-e69a-4b6f-8075-5b69068aa89b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 32649a72-cf51-44a4-abb8-481582ba3cd3
…

spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy fcff542b-a4f5-4ace-a0f1-45b99bc8f0ed
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 746d1751-9e4d-4895-86aa-f993879be0b7
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read f1eae7e4-96a9-491c-af79-c038f83bd279
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update 71f4dec1-a597-4d34-9711-5df2610011a2
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 32c50686-421e-4c63-a319-b78cf0a5abf4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 4a10d98e-bedc-46a9-b0f5-f61c60592698
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read ee2ace08-533c-4c6c-9690-78f612be4984
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update f60ceb22-cb32-4b1c-af34-3ce7ad71b72d
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy d274320b-c04c-4d7e-acc5-4820485ba930
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit e3663b0b-d197-44d9-8448-2e5e74da73db
…

♻️ This comment has been updated with latest results.

@laritakr laritakr merged commit 335eea4 into main Oct 16, 2024
8 of 9 checks passed
@laritakr laritakr deleted the based-near-fixes branch October 16, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShanaLMoore ShanaLMoore ShanaLMoore approved these changes

@kirkkwang kirkkwang kirkkwang approved these changes

Assignees
No one assigned
Labels
patch-ver for release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laritakr @ShanaLMoore @kirkkwang